Fixes off-by-one error when finding missing endstream #4404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/a0bae576605d244/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/427abca574f8ebb/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/427abca574f8ebb/output.txt Total script time: 25.30 mins
|
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/a0bae576605d244/output.txt Total script time: 35.50 mins
Image differences available at: http://107.22.172.223:8877/a0bae576605d244/reftest-analyzer.html#web=eq.log |
yurydelendik
added a commit
that referenced
this pull request
Mar 6, 2014
Fixes off-by-one error when finding missing endstream
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4387. Also removed unused variable
ii.Short explanation: we start with
i=0andj=0. Assume we find theeofendstreamimmediately. Thenjbecomes 1, butiis still 0.iwill be1in the next iteration, but when thenfromendstreamis then foundjbecomes 2, et cetera. In the end we will makejequal9and then stop, butiwill then be8. Therefore this patch increasesiby 1 to make them equal.